[Merged by Bors] - chore(LinearAlgebra/Matrix): deprecate Matrix.star_mul#38307
Closed
Vierkantor wants to merge 2 commits intoleanprover-community:masterfrom
Closed
[Merged by Bors] - chore(LinearAlgebra/Matrix): deprecate Matrix.star_mul#38307Vierkantor wants to merge 2 commits intoleanprover-community:masterfrom
Matrix.star_mul#38307Vierkantor wants to merge 2 commits intoleanprover-community:masterfrom
Conversation
This PR generalizes the `Matrix.starMul` instance so that `Matrix.star_mul` can be replaced with `star_mul` from the root namespace. I verified the two are exactly the same (after this generalization) by `with_reducible rfl`. I noticed this [while looking at docstrings](https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/.60star_mul.60.20is.20a.20version.20of.20.60star_mul.60.20for.20.60.2A.60.20instead.20of.20.60.2A.60/with/587815164).
Vierkantor
added
easy
PR summary 15d92c605bImport changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diff
You can run this locally as follows## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>The doc-module for No changes to technical debt.You can run this locally as
|
|
🚀 Pull request has been placed on the maintainer queue by themathqueen. |
mathlib-triage
Bot
added
the
maintainer-merge
Contributor
|
bors merge |
Contributor
|
Merge conflict. Merge or rebase |
mathlib-triage
Bot
added
ready-to-merge
mathlib-merge-conflicts
Bot
added
the
merge-conflict
|
This pull request has conflicts, please merge |
github-actions
Bot
removed
the
merge-conflict
Member
|
bors d+ bors merge |
Contributor
|
✌️ Vierkantor can now approve this pull request. To approve and merge a pull request, simply reply with |
mathlib-triage
Bot
added
the
delegated
mathlib-bors Bot
pushed a commit
that referenced
this pull request
Apr 21, 2026
This PR generalizes the `Matrix.starMul` instance so that `Matrix.star_mul` can be replaced with `star_mul` from the root namespace. I verified the two are exactly the same (after this generalization) by `with_reducible rfl`. I noticed this [while looking at docstrings](https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/.60star_mul.60.20is.20a.20version.20of.20.60star_mul.60.20for.20.60.2A.60.20instead.20of.20.60.2A.60/with/587815164). Co-authored-by: Anne C.A. Baanen <vierkantor@vierkantor.com>
Contributor
|
This PR was included in a batch that was canceled, it will be automatically retried |
mathlib-bors Bot
pushed a commit
that referenced
this pull request
Apr 21, 2026
This PR generalizes the `Matrix.starMul` instance so that `Matrix.star_mul` can be replaced with `star_mul` from the root namespace. I verified the two are exactly the same (after this generalization) by `with_reducible rfl`. I noticed this [while looking at docstrings](https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/.60star_mul.60.20is.20a.20version.20of.20.60star_mul.60.20for.20.60.2A.60.20instead.20of.20.60.2A.60/with/587815164). Co-authored-by: Anne C.A. Baanen <vierkantor@vierkantor.com>
Contributor
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
Bot
changed the title
Matrix.star_mulMatrix.star_mul
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR generalizes the
Matrix.starMulinstance so thatMatrix.star_mulcan be replaced withstar_mulfrom the root namespace. I verified the two are exactly the same (after this generalization) bywith_reducible rfl. I noticed this while looking at docstrings.